Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Julia versions in ci.yml #615

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

lbonaldo
Copy link
Collaborator

This updates the list of Julia versions in the ci.yml file and removes the tests on Julia nightly, as they are not allowed to fail. Reference: actions/runner#2347

@lbonaldo lbonaldo requested a review from sambuddhac January 23, 2024 14:47
@sambuddhac
Copy link
Collaborator

@lbonaldo I need a little clarification: So, on the nightly Julia tests, the allowed to fail setting was turned to "true." Why is it, then that you are mentioning that the nightly tests were not allowed to fail (and therefore, this PR removes the tests on nightly Julia?

Copy link
Collaborator

@sambuddhac sambuddhac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I am now convinced of its value. Approving it !!!

@sambuddhac sambuddhac merged commit da4869c into GenXProject:develop Jan 23, 2024
5 checks passed
@sambuddhac
Copy link
Collaborator

Okay, I am now convinced of its value. Approving it !!!

@lbonaldo lbonaldo deleted the ci-update-julia-versions branch January 23, 2024 18:34
@lbonaldo
Copy link
Collaborator Author

Thank you, @sambuddhac! In the future, we might add back the tests on the Julia nightly version if the allow_failure: true gets implemented or as a separate test.

@sambuddhac
Copy link
Collaborator

Thanks for clarifying, @lbonaldo. I totally agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants